base/thread_collision_warner.h - Issue 18677: Use PlatformThreadId, not int when dealing with thread ids.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/thread_collision_warner.h

Issue 18677: Use PlatformThreadId, not int when dealing with thread ids. (Closed)

Patch Set: Addressing comments Created 11 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/thread_collision_warner.h

diff --git a/base/thread_collision_warner.h b/base/thread_collision_warner.h

index fa8b7ee82a70ced33ec4c5c59ad96dc4864074a6..6545451bdd71f1d5d6f4082389952058d8c29236 100644

--- a/base/thread_collision_warner.h

+++ b/base/thread_collision_warner.h

@@ -225,7 +225,7 @@ class ThreadCollisionWarner {

// This stores the thread id that is inside the critical section, if the

// value is 0 then no thread is inside.

- volatile int valid_thread_id_;

+ volatile subtle::Atomic32 valid_thread_id_;

// Counter to trace how many time a critical section was "pinned"

// (when allowed) in order to unpin it when counter_ reaches 0.

« no previous file with comments | « base/thread.h ('k') | base/thread_collision_warner.cc » ('j') | no next file with comments »