Added handling of hidden prototype objects when collecting local properties f...

Added handling of hidden prototype objects when collecting local properties for an object mirror. The property names provided by an object mirror now includes all properties from the object and any hidden prototypes merged together.

Changed the name of Runtime_GetPrototype to Runtime_DebugGetPrototype to indicate that it is a debugger related function and changed its implementation to do the correct __proto__ lookup.

Added some more information to the Map debug print.

Committed: http://code.google.com/p/v8/source/detail?r=1126

[Mads Ager (chromium), 2009-01-22 13:13:05]

LGTM

http://codereview.chromium.org/18658/diff/205/207
File src/objects.cc (right):

http://codereview.chromium.org/18658/diff/205/207#newcode5700
Line 5700: NumberOfLocalProperties(static_cast<PropertyAttributes>(NONE)) -
index);
Indentation seems strange here.

http://codereview.chromium.org/18658/diff/205/208
File src/runtime.cc (right):

http://codereview.chromium.org/18658/diff/205/208#newcode4539
Line 4539: // Find the length of the prototype chain that is to to handle as
one. If the
to to handle -> to be handled

http://codereview.chromium.org/18658/diff/205/208#newcode4540
Line 4540: // a prototype object is hidden it is to be viewed as part of the the
object it
If the a -> If a

http://codereview.chromium.org/18658/diff/205/208#newcode4744
Line 4744: i == 0 ? 0 : local_property_count[i - 1]);
Indentation seems off here?

[Søren Thygesen Gjesse, 2009-01-22 13:19:52]

http://codereview.chromium.org/18658/diff/205/207
File src/objects.cc (right):

http://codereview.chromium.org/18658/diff/205/207#newcode5700
Line 5700: NumberOfLocalProperties(static_cast<PropertyAttributes>(NONE)) -
index);
On 2009/01/22 13:13:05, Mads Ager wrote:
> Indentation seems strange here.

Done.

http://codereview.chromium.org/18658/diff/205/208
File src/runtime.cc (right):

http://codereview.chromium.org/18658/diff/205/208#newcode4539
Line 4539: // Find the length of the prototype chain that is to to handle as
one. If the
On 2009/01/22 13:13:05, Mads Ager wrote:
> to to handle -> to be handled

Done.

http://codereview.chromium.org/18658/diff/205/208#newcode4540
Line 4540: // a prototype object is hidden it is to be viewed as part of the the
object it
On 2009/01/22 13:13:05, Mads Ager wrote:
> If the a -> If a

Done.

http://codereview.chromium.org/18658/diff/205/208#newcode4744
Line 4744: i == 0 ? 0 : local_property_count[i - 1]);
On 2009/01/22 13:13:05, Mads Ager wrote:
> Indentation seems off here?

Done.