Adds a command line switch to allow the user to specify the location...

chrome/browser/profile.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profile.h"
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/lock.h"
@@ skipping 475 matching lines @@
   std::wstring pref_file_path = path_;
   file_util::AppendToPath(&pref_file_path, chrome::kPreferencesFilename);
   return pref_file_path;
 }
 
 URLRequestContext* ProfileImpl::GetRequestContext() {
   if (!request_context_) {
     std::wstring cookie_path = GetPath();
     file_util::AppendToPath(&cookie_path, chrome::kCookieFilename);
     std::wstring cache_path = GetPath();
+
+    // Override the cache location if specified so

[rvargas (doing something else), 2009/01/27 03:55:20]

nit: Each comment has to be a complete sentence (and end with a period). Maybe
".. if specified by the user."

+    const std::wstring user_cache_dir(
+      CommandLine::ForCurrentProcess()->GetSwitchValue(

[rvargas (doing something else), 2009/01/27 03:55:20]

nit: wrong indentation. See http://dev.chromium.org/developers/coding-style

+        switches::kDiskCacheLocation));
+    if (!user_cache_dir.empty()) {
+      // Create the directory if necessary. The browser needs it to
+      // exist to populate it.
+      if (file_util::DirectoryExists(user_cache_dir) ||

[rvargas (doing something else), 2009/01/27 03:55:20]

Remove all the code that creates the folder. That should be performed by the
lower layers.

+        file_util::CreateDirectory(user_cache_dir)) {
+        // This last check reflects the real need - we need a directory
+        // that we can add content to
+        if (file_util::PathIsWritable(user_cache_dir)) {
+          cache_path = user_cache_dir;
+        } else {
+        // Failing silently is the idea here, since this functionality is
+        // simply not important. If the user has specified an unusable
+        // path, the user can figure out how to make it work. If he cannot,
+        // he is probably not the kind of user who would care about moving
+        // the cache anyway. Command line options will eventually have
+        // to be documented somewhere, and then we can document the
+        // condition that the path must exist or its immediate parent
+        // must be writable.
+        }
+      }
+    }
+
     file_util::AppendToPath(&cache_path, chrome::kCacheDirname);
     request_context_ = ChromeURLRequestContext::CreateOriginal(
         this, cookie_path, cache_path);
     request_context_->AddRef();
 
     // The first request context is always a normal (non-OTR) request context.
     // Even when Chromium is started in OTR mode, a normal profile is always
     // created first.
     if (!default_request_context_) {
       default_request_context_ = request_context_;
       NotificationService::current()->Notify(
           NOTIFY_DEFAULT_REQUEST_CONTEXT_AVAILABLE,
           NotificationService::AllSources(), NotificationService::NoDetails());
     }
 
     DCHECK(request_context_->cookie_store());
   }
 

[rvargas (doing something else), 2009/01/27 03:55:20]

nit: remove

+
   return request_context_;
 }
 
 HistoryService* ProfileImpl::GetHistoryService(ServiceAccessType sat) {
   if (!history_service_created_) {
     history_service_created_ = true;
     scoped_refptr<HistoryService> history(new HistoryService(this));
     if (!history->Init(GetPath(), GetBookmarkModel()))
       return NULL;
     history_service_.swap(history);
@@ skipping 234 matching lines @@
 }
 
 #ifdef CHROME_PERSONALIZATION
 ProfilePersonalization* ProfileImpl::GetProfilePersonalization() {
   if (!personalization_.get())
     personalization_.reset(
         Personalization::CreateProfilePersonalization(this));
   return personalization_.get();
 }
 #endif