Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Side by Side Diff: src/regexp-macro-assembler-irregexp-inl.h

Issue 18613: Fix endianism issues in regexp interpreter. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/regexp-macro-assembler-irregexp.cc ('k') | src/utils.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 25 matching lines...) Expand all
36 namespace v8 { namespace internal { 36 namespace v8 { namespace internal {
37 37
38 38
39 void RegExpMacroAssemblerIrregexp::Emit(uint32_t byte, 39 void RegExpMacroAssemblerIrregexp::Emit(uint32_t byte,
40 uint32_t twenty_four_bits) { 40 uint32_t twenty_four_bits) {
41 uint32_t word = ((twenty_four_bits << BYTECODE_SHIFT) | byte); 41 uint32_t word = ((twenty_four_bits << BYTECODE_SHIFT) | byte);
42 ASSERT(pc_ <= buffer_.length()); 42 ASSERT(pc_ <= buffer_.length());
43 if (pc_ + 3 >= buffer_.length()) { 43 if (pc_ + 3 >= buffer_.length()) {
44 Expand(); 44 Expand();
45 } 45 }
46 Store32(buffer_.start() + pc_, word); 46 *reinterpret_cast<uint32_t*>(buffer_.start() + pc_) = word;
47 pc_ += 4; 47 pc_ += 4;
48 } 48 }
49 49
50 50
51 void RegExpMacroAssemblerIrregexp::Emit16(uint32_t word) { 51 void RegExpMacroAssemblerIrregexp::Emit16(uint32_t word) {
52 ASSERT(pc_ <= buffer_.length()); 52 ASSERT(pc_ <= buffer_.length());
53 if (pc_ + 1 >= buffer_.length()) { 53 if (pc_ + 1 >= buffer_.length()) {
54 Expand(); 54 Expand();
55 } 55 }
56 Store16(buffer_.start() + pc_, word); 56 *reinterpret_cast<uint16_t*>(buffer_.start() + pc_) = word;
57 pc_ += 2; 57 pc_ += 2;
58 } 58 }
59 59
60 60
61 void RegExpMacroAssemblerIrregexp::Emit32(uint32_t word) { 61 void RegExpMacroAssemblerIrregexp::Emit32(uint32_t word) {
62 ASSERT(pc_ <= buffer_.length()); 62 ASSERT(pc_ <= buffer_.length());
63 if (pc_ + 3 >= buffer_.length()) { 63 if (pc_ + 3 >= buffer_.length()) {
64 Expand(); 64 Expand();
65 } 65 }
66 Store32(buffer_.start() + pc_, word); 66 *reinterpret_cast<uint32_t*>(buffer_.start() + pc_) = word;
67 pc_ += 4; 67 pc_ += 4;
68 } 68 }
69 69
70 70
71 } } // namespace v8::internal 71 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/regexp-macro-assembler-irregexp.cc ('k') | src/utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698