Remove ATL from wmi_util...

Remove ATL from wmi_util
- CComptr and CComBstr gone, baby gone
- scoped_comptr_win.h file had a CRLF or at least VC thinks so
- Future work: Grow variant helper class to be really helpful
- Unit tests already exist

It seems base is now free of ATL


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8419

[tommi (sloooow) - chröme, 2009-01-21 18:57:57]

for some reason I'm not seeing the change to scoped_comptr_win.h

http://codereview.chromium.org/18610/diff/202/7
File base/scoped_comptr_win.h (right):

http://codereview.chromium.org/18610/diff/202/7#newcode5
Line 5: #ifndef BASE_SCOPED_COMPTR_WIN_H_
I'm not seeing any changes in this file?

http://codereview.chromium.org/18610/diff/202/8
File base/wmi_util.cc (right):

http://codereview.chromium.org/18610/diff/202/8#newcode16
Line 16: class VariantHelper : public VARIANT {
nice... fyi, I've got a scoped_variant in the works, but will update this once
that's complete.

http://codereview.chromium.org/18610/diff/202/8#newcode19
Line 19: ::VariantInit(this);
fyi - all VariantInit does is set vt = VT_EMPTY.  You could do that yourself in
the constructor to inline-enable it and avoid the function call

http://codereview.chromium.org/18610/diff/202/8#newcode22
Line 22: ::VariantInit(this);
VariantInit isn't necessary

http://codereview.chromium.org/18610/diff/202/8#newcode44
Line 44: NULL, 0, 0, wmi_services_r.Receive());
use StackBstr instead of ScopedBstr here

http://codereview.chromium.org/18610/diff/202/8#newcode125
Line 125: HRESULT hr = wmi_local->ExecMethod(ScopedBstr(class_name),
StackBstr for first two arguments

[tommi (sloooow) - chröme, 2009-01-21 18:59:43]

LGTM with suggestions from my first reply

reading the description told me why I wasn't noticing the whitespace changes
(doh) :)  thanks for fixing.

[cpu_(ooo_6.6-7.5), 2009-01-21 20:27:52]

Thanks for the review. I'll commit in a few minutes.

Lets chat sometime about the next set of high impact atl replacements.

http://codereview.chromium.org/18610/diff/202/8
File base/wmi_util.cc (right):

http://codereview.chromium.org/18610/diff/202/8#newcode16
Line 16: class VariantHelper : public VARIANT {
On 2009/01/21 18:57:57, tommi wrote:
> nice... fyi, I've got a scoped_variant in the works, but will update this once
> that's complete.

Cool. I was hoping you wanted to :)  Added TODO(tommi) here.

http://codereview.chromium.org/18610/diff/202/8#newcode19
Line 19: ::VariantInit(this);
On 2009/01/21 18:57:57, tommi wrote:
> fyi - all VariantInit does is set vt = VT_EMPTY.  You could do that yourself
in
> the constructor to inline-enable it and avoid the function call

Done.

http://codereview.chromium.org/18610/diff/202/8#newcode22
Line 22: ::VariantInit(this);
On 2009/01/21 18:57:57, tommi wrote:
> VariantInit isn't necessary

Done.

http://codereview.chromium.org/18610/diff/202/8#newcode44
Line 44: NULL, 0, 0, wmi_services_r.Receive());
On 2009/01/21 18:57:57, tommi wrote:
> use StackBstr instead of ScopedBstr here

Done.

http://codereview.chromium.org/18610/diff/202/8#newcode125
Line 125: HRESULT hr = wmi_local->ExecMethod(ScopedBstr(class_name),
On 2009/01/21 18:57:57, tommi wrote:
> StackBstr for first two arguments

Done.