Add a replace_all param to ReplaceSubstringsAfterOffset and update call sites.

Add a replace_all param to ReplaceSubstringsAfterOffset and update call sites.

[Erik does not do reviews, 2009-01-21 17:39:09]

http://codereview.chromium.org/18603/diff/1/3
File base/string_util.h (right):

http://codereview.chromium.org/18603/diff/1/3#newcode325
Line 325: // all instances. Otherwise, replaces just the first instance.
A cleaner way to implement this would be to split this into three functions. 
Leave the existing one as-is, add a ReplaceSubstring (no s), and then have a
shared private function (which already exists) that takes the replace_all
argument.  That way you don't have to change all of the existing call sites.  If
you don't like the naming of ReplaceSubstring vs. ReplaceSubstrings, then name
the second one ReplaceOneSubstring or name the first one ReplaceAllSubstrings. 
Even if you have to touch all of the callsites, I still like this much better
than a boolean.

[Aaron Boodman, 2009-01-21 21:51:52]

http://codereview.chromium.org/18603/diff/1/3
File base/string_util.h (right):

http://codereview.chromium.org/18603/diff/1/3#newcode325
Line 325: // all instances. Otherwise, replaces just the first instance.
On 2009/01/21 17:39:09, Erik Kay wrote:
> A cleaner way to implement this would be to split this into three functions. 
> Leave the existing one as-is, add a ReplaceSubstring (no s), and then have a
> shared private function (which already exists) that takes the replace_all
> argument.  That way you don't have to change all of the existing call sites. 
If
> you don't like the naming of ReplaceSubstring vs. ReplaceSubstrings, then name
> the second one ReplaceOneSubstring or name the first one ReplaceAllSubstrings.

> Even if you have to touch all of the callsites, I still like this much better
> than a boolean.

Good point, that is much cleaner. Done.

[Erik does not do reviews, 2009-01-21 22:05:02]

LGTM - much nicer