Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Issue 18586: Reduce the size of a release test_shell from 18mb to 13mb. (Closed)

Created:
11 years, 11 months ago by Dean McNamee
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Reduce the size of a release test_shell from 18mb to 12mb. - Strip all symbols. We previously had many exported symbols. - GC sections. -fdata/function-sections make sure each piece of code/data has it's own section, since GC works on an entire section. I will follow up on the V8 build with the same. - Remove the ident pragmas. For example, we previously had a string like: GCC: (GNU) 4.2.4 (Ubuntu 4.2.4-1ubuntu1) Repeated in the .comment section (one for each object?). This data is just metadata.

Patch Set 1 #

Patch Set 2 : GC sections #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M build/SConscript.main View 1 2 chunks +7 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Dean McNamee
This is some simple low hanging stuff. The ident was only 80k, but it's still ...
11 years, 11 months ago (2009-01-26 12:06:41 UTC) #1
Dean McNamee
Now 12mb. Adding Mark.
11 years, 11 months ago (2009-01-26 17:25:43 UTC) #2
sgk
lgtm
11 years, 11 months ago (2009-01-26 17:38:50 UTC) #3
Mark Mentovai
lgtm, good work
11 years, 11 months ago (2009-01-26 17:48:31 UTC) #4
Evan Martin
For random people running random self-compiled binaries, they will no longer be able to get ...
11 years, 11 months ago (2009-01-26 18:12:11 UTC) #5
Lei Zhang
11 years, 11 months ago (2009-01-26 22:21:23 UTC) #6
http://codereview.chromium.org/18586/diff/202/203
File build/SConscript.main (right):

http://codereview.chromium.org/18586/diff/202/203#newcode531
Line 531: linux_env.Append(LINKFLAGS_OPTIMIZED=['-Wl,--gc-sections', '-s'])
FYI, gold does not support --gc-sections.

Powered by Google App Engine
This is Rietveld 408576698