Issue 18585: Handle strndup in freebsd in the same way it is handled on other...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18585: Handle strndup in freebsd in the same way it is handled on other... (Closed)

Created:
11 years, 11 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, alexbl, alexbl

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Handle strndup in freebsd in the same way it is handled on other platforms that do not support it directly. Committed: http://code.google.com/p/v8/source/detail?r=1148

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -5 lines)			Patch
M	src/platform-freebsd.cc	View	1 chunk	+13 lines, -1 line	0 comments	Download
M	src/platform-macos.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/platform-win32.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

FreeBSD does not support strndup as reported by Alex (V8 issue 202). Use the custom ...

11 years, 11 months ago (2009-01-26 10:49:35 UTC) #1

Søren Thygesen Gjesse

On 2009/01/26 10:49:35, Mads Ager wrote: > FreeBSD does not support strndup as reported by ...

11 years, 11 months ago (2009-01-26 11:26:33 UTC) #2

alexbl

11 years, 11 months ago (2009-01-26 17:01:01 UTC) #3

On 2009/01/26 11:26:33, Søren Gjesse wrote:
> On 2009/01/26 10:49:35, Mads Ager wrote:
> > FreeBSD does not support strndup as reported by Alex (V8 issue 202).  Use
the
> > custom implementation also used on macos and win32.
> 
> LGTM - how did V8 build on FreeBSD in the first place?
When I initially did the platform file for FreeBSD, there was no StrNDup in
there.

Expand Messages | Collapse Messages