Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 18583: Change type of snapshot from char array to byte array to avoid portability pr... (Closed)

Created:
11 years, 11 months ago by olehougaard
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Change type of snapshot from char array to byte array to avoid portability problems between different compilers. Committed: http://code.google.com/p/v8/source/detail?r=1145

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -36 lines) Patch
M src/mksnapshot.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M src/serialize.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/serialize.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M src/snapshot.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/snapshot-common.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/snapshot-empty.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/utils.h View 2 chunks +11 lines, -3 lines 0 comments Download
M src/utils.cc View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
olehougaard
11 years, 11 months ago (2009-01-26 10:03:51 UTC) #1
Mads Ager (chromium)
11 years, 11 months ago (2009-01-26 10:11:53 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698