Issue 18582: Revert change to Smi check that was a performance regression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18582: Revert change to Smi check that was a performance regression. (Closed)

Created:
11 years, 11 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Revert change to Smi check that was a performance regression. Committed: http://code.google.com/p/v8/source/detail?r=1143

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	src/codegen-ia32.cc	View		1 chunk	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

William Hesse

11 years, 11 months ago (2009-01-26 09:08:01 UTC) #1

This optimization in change 18551 turns out to be a performance regression.  The
picture is a little mixed, but many bitops tests suffer significantly.

Expand Messages | Collapse Messages