Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 18581: Enable preemption in d8. (Closed)

Created:
11 years, 11 months ago by iposva
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

- Preserve bootstrapper state across thread switches (fixes issue 143). - Make sure stack guards are properly setup even when preemption is active. - Fix missing v8::Locker and v8::Unlocker use in d8.cc. - Threads forked in d8 do get their own context setup. Committed: http://code.google.com/p/v8/source/detail?r=1161

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -57 lines) Patch
M src/bootstrapper.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +46 lines, -0 lines 0 comments Download
M src/d8.cc View 5 chunks +71 lines, -46 lines 0 comments Download
M src/execution.h View 1 1 chunk +6 lines, -1 line 0 comments Download
M src/execution.cc View 2 chunks +20 lines, -6 lines 0 comments Download
M src/runtime.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/top.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/v8threads.cc View 5 chunks +10 lines, -1 line 0 comments Download
M tools/v8.xcodeproj/project.pbxproj View 15 chunks +125 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
iposva
I will file the bug for the TODO after this change is reviewed. -Ivan
11 years, 11 months ago (2009-01-26 05:25:27 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/18581/diff/1/4 File src/bootstrapper.cc (right): http://codereview.chromium.org/18581/diff/1/4#newcode268 Line 268: // Support for thread preemption. Do you ...
11 years, 11 months ago (2009-01-26 07:42:51 UTC) #2
iposva
Reply to comment and small update to top.cc -Ivan http://codereview.chromium.org/18581/diff/1/4 File src/bootstrapper.cc (right): http://codereview.chromium.org/18581/diff/1/4#newcode268 Line ...
11 years, 11 months ago (2009-01-26 17:32:13 UTC) #3
Mads Ager (chromium)
11 years, 11 months ago (2009-01-26 17:50:42 UTC) #4
LGTM!

Powered by Google App Engine
This is Rietveld 408576698