Issue 18575: Do no use custom gtkrc files in layout test mode....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18575: Do no use custom gtkrc files in layout test mode.... (Closed)

Created:
11 years, 11 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Do no use custom gtkrc files in layout test mode. On desktop environments like KDE, custom gtkrc files prevent test shell from setting the theme correctly.

Patch Set 1 #

Total comments: 1

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	webkit/tools/test_shell/test_shell_main.cc	View		1 chunk	+5 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

Not sure who is the best person to review this, so defaulting to you.

11 years, 11 months ago (2009-01-24 01:30:21 UTC) #1

Evan Martin

11 years, 11 months ago (2009-01-24 01:39:20 UTC) #2

lgtm

http://codereview.chromium.org/18575/diff/1/2
File webkit/tools/test_shell/test_shell_main.cc (right):

http://codereview.chromium.org/18575/diff/1/2#newcode236
Line 236: gchar *default_gtkrc_files[] = { NULL };
star on the left (gchar* default...)

Expand Messages | Collapse Messages