Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1857001: Revert "Changing string length field type from int to SMI." (Closed)

Created:
10 years, 7 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Revert "Changing string length field type from int to SMI." This reverts svn commit 4556 from trunk. Committed: http://code.google.com/p/v8/source/detail?r=4563

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -245 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/codegen-arm.cc View 8 chunks +9 lines, -21 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 5 chunks +21 lines, -36 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 26 chunks +26 lines, -42 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 2 chunks +5 lines, -3 lines 0 comments Download
M src/x64/codegen-x64.cc View 22 chunks +39 lines, -54 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 3 chunks +1 line, -8 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 7 chunks +7 lines, -63 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
10 years, 7 months ago (2010-05-03 08:00:15 UTC) #1
Mads Ager (chromium)
10 years, 7 months ago (2010-05-03 08:41:07 UTC) #2
LGTM, thanks Kevin!

Powered by Google App Engine
This is Rietveld 408576698