Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 18555: Prep for generated .vcproj files:... (Closed)

Created:
11 years, 11 months ago by sgk
Modified:
9 years, 5 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Prep for generated .vcproj files: Fix minor stylistic inconsistencies in some .vcproj files: * /> tag termination: net\net_resources.vcproj * Add empty <ToolFiles>, <References> and <Globals> sections: net\net_resources.vcproj third_party\zlib\zlib.vcproj third_party\libpng\libpng.vcproj chrome\tools\test\image_diff\image_diff.vcproj * Remove .\ on file names where its use is inconsistent with the rest of the file names in the .vcproj: net\build\net.vcproj net\build\net_unittests.vcproj chrome\installer\util\util.vcproj * Add explicit RootNamespace attribute: chrome\test\automation\automation.vcproj testing\gtest.vcproj * Fix file order in four locales that don't match other locale .vcproj files: chrome\app\locales\da.vcproj chrome\app\locales\he.vcproj chrome\app\locales\zh-TW.vcproj chrome\app\locales\en-US.vcproj * Remove duplicate files from the list: chrome\browser\views\browser_views.vcproj (event_utils.[ch]) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8577

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -59 lines) Patch
M chrome/app/locales/da.vcproj View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/locales/en-US.vcproj View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/locales/he.vcproj View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/locales/zh-TW.vcproj View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/views/browser_views.vcproj View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/installer/util/util.vcproj View 1 5 chunks +34 lines, -34 lines 0 comments Download
M chrome/test/automation/automation.vcproj View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/test/image_diff/image_diff.vcproj View 1 2 chunks +6 lines, -0 lines 0 comments Download
M net/build/net.vcproj View 1 3 chunks +3 lines, -3 lines 0 comments Download
M net/build/net_resources.vcproj View 1 2 chunks +6 lines, -4 lines 0 comments Download
M net/build/net_unittests.vcproj View 1 2 chunks +2 lines, -2 lines 0 comments Download
M testing/gtest.vcproj View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libpng/libpng.vcproj View 1 3 chunks +6 lines, -0 lines 0 comments Download
M third_party/zlib/zlib.vcproj View 1 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sgk
This updates some .vcproj files that have stylistic inconsistencies with (most of) the rest, so ...
11 years, 11 months ago (2009-01-23 17:41:11 UTC) #1
Nicolas Sylvain
LGTM, with a nit, but if you think it's right I have no problem with ...
11 years, 11 months ago (2009-01-23 18:09:05 UTC) #2
sgk
http://codereview.chromium.org/18555/diff/1/3 File net/build/net.vcproj (right): http://codereview.chromium.org/18555/diff/1/3#newcode384 Line 384: RelativePath="precompiled_net.cc" On 2009/01/23 18:09:05, Nicolas Sylvain wrote: > ...
11 years, 11 months ago (2009-01-23 18:26:09 UTC) #3
M-A Ruel
lgtm
11 years, 11 months ago (2009-01-23 18:28:11 UTC) #4
darin (slow to review)
11 years, 11 months ago (2009-01-23 20:55:40 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698