Issue 18551: Optimizes an assembly-language conversion from int to Smi in codegen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18551: Optimizes an assembly-language conversion from int to Smi in codegen. (Closed)

Created:
11 years, 11 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
iposva, Kevin Millikin (Chromium), Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Optimizes an assembly-language conversion from int to Smi in codegen. Committed: http://code.google.com/p/v8/source/detail?r=1137

Patch Set 1 #

Total comments: 2

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	src/codegen-ia32.cc	View		1 chunk	+8 lines, -8 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

iposva

http://codereview.chromium.org/18551/diff/1/2 File src/codegen-ia32.cc (right): http://codereview.chromium.org/18551/diff/1/2#newcode1132 Line 1132: ASSERT(kSmiTagSize == times_2); // Adjust code if not ...

11 years, 11 months ago (2009-01-23 16:58:38 UTC) #3

Kevin Millikin (Chromium)

11 years, 11 months ago (2009-01-23 18:48:08 UTC) #4

http://codereview.chromium.org/18551/diff/1/2
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/18551/diff/1/2#newcode1129
Line 1129: __ shl(ebx, shift_value);
It's late in the day so I could be wrong.

Do we really need to shift right kSmiTagSize, shift left shift_value, and then
shift left kSmiTagSize to reapply the tag?  Analogous to a multiply, can't we
just shift the tagged value if the tag is zero?

Expand Messages | Collapse Messages