Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2561)

Unified Diff: chrome/browser/browser_window.h

Issue 18540: Don't expose the go and star button views directly through the BrowserWindow ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_commands_unittest.cc ('k') | chrome/browser/browser_window_cocoa.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_window.h
===================================================================
--- chrome/browser/browser_window.h (revision 8515)
+++ chrome/browser/browser_window.h (working copy)
@@ -10,14 +10,12 @@
class BrowserList;
class BrowserView;
class BrowserWindowTesting;
-class GoButton;
+class GURL;
class LocationBarView;
class HtmlDialogContentsDelegate;
class Profile;
class StatusBubble;
class TabContents;
-class TabStrip;
-class ToolbarStarToggle;
namespace gfx {
class Rect;
@@ -59,10 +57,6 @@
// if there is none.
virtual BrowserWindowTesting* GetBrowserWindowTesting() = 0;
- // TODO(beng): REMOVE (obtain via BrowserFrame).
- // Return the TabStrip associated with the frame.
- virtual TabStrip* GetTabStrip() const = 0;
-
// Return the status bubble associated with the frame
virtual StatusBubble* GetStatusBubble() = 0;
@@ -82,6 +76,9 @@
// if there are no active loads and the animations should end.
virtual void UpdateLoadingAnimations(bool should_animate) = 0;
+ // Sets the starred state for the current tab.
+ virtual void SetStarredState(bool is_starred) = 0;
+
// TODO(beng): RENAME (GetRestoredBounds)
// Returns the nonmaximized bounds of the frame (even if the frame is
// currently maximized or minimized) in terms of the screen coordinates.
@@ -91,14 +88,12 @@
// Returns true if the frame is maximized (aka zoomed).
virtual bool IsMaximized() = 0;
- // Returns the star button.
- virtual ToolbarStarToggle* GetStarButton() const = 0;
-
// Returns the location bar.
virtual LocationBarView* GetLocationBarView() const = 0;
- // Returns the go button.
- virtual GoButton* GetGoButton() const = 0;
+ // Informs the view whether or not a load is in progress for the current tab.
+ // The view can use this notification to update the go/stop button.
+ virtual void UpdateStopGoState(bool is_loading) = 0;
// Updates the toolbar with the state for the specified |contents|.
virtual void UpdateToolbar(TabContents* contents,
@@ -119,6 +114,13 @@
// Shows the Bookmark Manager window.
virtual void ShowBookmarkManager() = 0;
+ // Returns true if the Bookmark bubble is visible.
+ virtual bool IsBookmarkBubbleVisible() const = 0;
+
+ // Shows the Bookmark bubble. |url| is the URL being bookmarked,
+ // |already_bookmarked| is true if the url is already bookmarked.
+ virtual void ShowBookmarkBubble(const GURL& url, bool already_bookmarked) = 0;
+
// Shows the Report a Bug dialog box.
virtual void ShowReportBugDialog() = 0;
« no previous file with comments | « chrome/browser/browser_commands_unittest.cc ('k') | chrome/browser/browser_window_cocoa.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698