Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Side by Side Diff: chrome/browser/browser.h

Issue 18540: Don't expose the go and star button views directly through the BrowserWindow ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/browser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BROWSER_H_ 5 #ifndef CHROME_BROWSER_BROWSER_H_
6 #define CHROME_BROWSER_BROWSER_H_ 6 #define CHROME_BROWSER_BROWSER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 9
10 #include <vector> 10 #include <vector>
(...skipping 408 matching lines...) Expand 10 before | Expand all | Expand 10 after
419 void InitCommandState(); 419 void InitCommandState();
420 420
421 // Update commands which may be enabled or disabled depending on the tab's 421 // Update commands which may be enabled or disabled depending on the tab's
422 // state. 422 // state.
423 void UpdateCommandsForTabState(); 423 void UpdateCommandsForTabState();
424 424
425 // Set the correct stop/go icon and update the Go and Stop command states. 425 // Set the correct stop/go icon and update the Go and Stop command states.
426 // |is_loading| is true if the current TabContents is loading. 426 // |is_loading| is true if the current TabContents is loading.
427 void UpdateStopGoState(bool is_loading); 427 void UpdateStopGoState(bool is_loading);
428 428
429 // Change the "starred" button display to starred/unstarred.
430 // TODO(evanm): migrate this to the commands framework.
431 void SetStarredButtonToggled(bool starred);
432
433 #if defined(OS_WIN) 429 #if defined(OS_WIN)
434 // UI update coalescing and handling //////////////////////////////////////// 430 // UI update coalescing and handling ////////////////////////////////////////
435 431
436 // Asks the toolbar (and as such the location bar) to update its state to 432 // Asks the toolbar (and as such the location bar) to update its state to
437 // reflect the current tab's current URL, security state, etc. 433 // reflect the current tab's current URL, security state, etc.
438 // If |should_restore_state| is true, we're switching (back?) to this tab and 434 // If |should_restore_state| is true, we're switching (back?) to this tab and
439 // should restore any previous location bar state (such as user editing) as 435 // should restore any previous location bar state (such as user editing) as
440 // well. 436 // well.
441 void UpdateToolbar(bool should_restore_state); 437 void UpdateToolbar(bool should_restore_state);
442 438
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
648 // The browser idle task helps cleanup unused memory resources when idle. 644 // The browser idle task helps cleanup unused memory resources when idle.
649 scoped_ptr<BrowserIdleTimer> idle_task_; 645 scoped_ptr<BrowserIdleTimer> idle_task_;
650 646
651 // Keep track of the encoding auto detect pref. 647 // Keep track of the encoding auto detect pref.
652 BooleanPrefMember encoding_auto_detect_; 648 BooleanPrefMember encoding_auto_detect_;
653 649
654 DISALLOW_COPY_AND_ASSIGN(Browser); 650 DISALLOW_COPY_AND_ASSIGN(Browser);
655 }; 651 };
656 652
657 #endif // CHROME_BROWSER_BROWSER_H_ 653 #endif // CHROME_BROWSER_BROWSER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698