Issue 18535: Decrements FieldTrialList::constructor_count_ in the destructor. I'm...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18535: Decrements FieldTrialList::constructor_count_ in the destructor. I'm... (Closed)

Created:
11 years, 11 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Decrements FieldTrialList::constructor_count_ in the destructor. I'm going to run ui tests in process and call BrowserMain multiple times. That means FieldTrialList's constructor is run multiple times. Without this decrement, the constructor isn't happy. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8554

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -10 lines)			Patch
M	base/field_trial.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	base/field_trial.cc	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
M	base/field_trial_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Thanks!!!!

Expand Messages | Collapse Messages