Issue 18529: Removing unneeded code from SimpleFontData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18529: Removing unneeded code from SimpleFontData. (Closed)

Created:
11 years, 11 months ago by dglazkov

Modified:
9 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Removing unneeded code from SimpleFontData. R=brettw Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8646

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -153 lines)			Patch
M	third_party/WebKit/WebCore/platform/graphics/SimpleFontData.h	View		6 chunks	+1 line, -40 lines	0 comments	Download
M	third_party/WebKit/WebCore/platform/graphics/SimpleFontData.cpp	View		6 chunks	+0 lines, -101 lines	0 comments	Download
M	third_party/WebKit/WebCore/platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp	View	1	1 chunk	+2 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

11 years, 11 months ago (2009-01-23 18:53:16 UTC) #2

LGTM. For the record, I think there's a 50% chance this will break the direction
markers in Gmail again on some people's computers, so be ready to revert :)

Expand Messages | Collapse Messages