Issue 18502: Clean up the mark-sweep/compact collector by removing outdated...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18502: Clean up the mark-sweep/compact collector by removing outdated... (Closed)

Created:
11 years, 11 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Clean up the mark-sweep/compact collector by removing outdated verification code and updating outdated comments. Committed: http://code.google.com/p/v8/source/detail?r=1131

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -228 lines)			Patch
	M	src/mark-compact.h	View	1	8 chunks	+78 lines, -62 lines	1 comment	Download
	M	src/mark-compact.cc	View		10 chunks	+5 lines, -166 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 11 months ago (2009-01-22 18:37:23 UTC) #2

LGTM.  

Do we have all the verification code that we would like in the
mark-sweep/compact collector or should the stuff you have now removed be
replaced by something similar that makes sense for the current collector?

http://codereview.chromium.org/18502/diff/4/203
File src/mark-compact.h (right):

http://codereview.chromium.org/18502/diff/4/203#newcode238
Line 238: //          Bookkeeping data is written to the remembered-set are of
are of eached -> of each

Expand Messages | Collapse Messages