Issue 18489: Rebaseline tests where sizes are off by 1 due to font differences....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18489: Rebaseline tests where sizes are off by 1 due to font differences.... (Closed)

Created:
11 years, 11 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Rebaseline tests where sizes are off by 1 due to font differences. For fast/forms/input-baseline.html, RenderTextControl::calcHeight() uses the value from m_innerText->renderer()->lineHeight(true, true), but RenderFlow::lineHeight() returns s->font().lineSpacing(), which is off by 1. For fast/forms/textfield-outline.html, it comes down to RenderTextControlSingleLine::preferredContentWidth() calling style()->font().primaryFont()->maxCharWidth() which returns a value that's off by 1.

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -2 lines)			Patch
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/forms/input-baseline-expected.txt	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/forms/textfield-outline-expected.txt	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	webkit/tools/layout_tests/test_lists/tests_fixable.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

Try again from my chromium account instead of my gmail account.

11 years, 11 months ago (2009-01-22 02:32:51 UTC) #1

LGTM still stands

Expand Messages | Collapse Messages