Issue 18478: Include webkit strings in test shell data pack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18478: Include webkit strings in test shell data pack. (Closed)

Created:
11 years, 11 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Include webkit strings in test shell data pack. This adds <message> node to the types of GRIT nodes that we can stuff into a data package file and removes a test shell hack.

Patch Set 1 #

Patch Set 2 : comment #

Total comments: 2

Patch Set 3 : remove header #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -139 lines)			Patch
M	tools/grit/grit/format/data_pack.py	View		3 chunks	+5 lines, -4 lines	0 comments	Download
M	tools/grit/grit/node/include.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/grit/grit/node/message.py	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	webkit/glue/webkit_strings.grd	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/SConscript	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_gtk.cc	View	1 2	2 chunks	+5 lines, -133 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

11 years, 11 months ago (2009-01-22 00:58:45 UTC) #2

LGTM

http://codereview.chromium.org/18478/diff/207/213
File webkit/tools/test_shell/test_shell_gtk.cc (left):

http://codereview.chromium.org/18478/diff/207/213#oldcode36
Line 36: // TODO(deanm): Needed for the localized string shim.
If this TODO is fixed, maybe remove the include?

http://codereview.chromium.org/18478/diff/207/213
File webkit/tools/test_shell/test_shell_gtk.cc (right):

http://codereview.chromium.org/18478/diff/207/213#newcode686
Line 686: return UTF8ToWide(res.as_string());
Too bad this makes a copy.  We should fix UTF8ToWide at some point.  :)

Expand Messages | Collapse Messages