Issue 18447: Share DidProcessCrash between Linux and Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18447: Share DidProcessCrash between Linux and Mac. (Closed)

Created:
11 years, 11 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, pink (ping after 24hrs), dank

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Share DidProcessCrash between Linux and Mac.

Patch Set 1 #

Total comments: 2

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -25 lines)			Patch
	M	base/process_util_linux.cc	View		2 chunks	+1 line, -25 lines	0 comments	Download
	M	base/process_util_posix.cc	View		1 chunk	+25 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

I think this could should be the same on the Mac, right?

11 years, 11 months ago (2009-01-21 13:45:52 UTC) #1

Mark Mentovai

http://codereview.chromium.org/18447/diff/1/3 File base/process_util_posix.cc (right): http://codereview.chromium.org/18447/diff/1/3#newcode109 Line 109: case SIGSEGV: SIGBUS? http://codereview.chromium.org/18447/diff/1/3#newcode120 Line 120: return WEXITSTATUS(status) ...

11 years, 11 months ago (2009-01-21 14:20:21 UTC) #3

Dean McNamee

11 years, 11 months ago (2009-01-21 14:39:18 UTC) #4

Yeah, it seems like any exit due to an signal should be considered a crash. 
Dan?

On 2009/01/21 14:20:21, Mark Mentovai wrote:
> http://codereview.chromium.org/18447/diff/1/3
> File base/process_util_posix.cc (right):
> 
> http://codereview.chromium.org/18447/diff/1/3#newcode109
> Line 109: case SIGSEGV:
> SIGBUS?
> 
> http://codereview.chromium.org/18447/diff/1/3#newcode120
> Line 120: return WEXITSTATUS(status) != 0;
> That's not really a crash, though...

Expand Messages | Collapse Messages