Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 18445: Changes to the mirror handling... (Closed)

Created:
11 years, 11 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Changes to the mirror handling When getting properties for the global object proxy the properties from the global object are returned. Script objects now have handles and are serialized by reference. Added special handling for NaN. Committed: http://code.google.com/p/v8/source/detail?r=1116

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -7 lines) Patch
M src/mirror-delay.js View 6 chunks +20 lines, -5 lines 0 comments Download
M src/runtime.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/mjsunit/mirror-number.js View 1 chunk +9 lines, -1 line 0 comments Download
M test/mjsunit/mirror-object.js View 2 chunks +7 lines, -1 line 2 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
11 years, 11 months ago (2009-01-21 08:55:12 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/18445/diff/1/2 File test/mjsunit/mirror-object.js (right): http://codereview.chromium.org/18445/diff/1/2#newcode139 Line 139: if (properties[i].value().isNumber() && isNaN(properties[i].value().value())) { A couple ...
11 years, 11 months ago (2009-01-21 09:18:34 UTC) #2
Søren Thygesen Gjesse
11 years, 11 months ago (2009-01-21 09:31:39 UTC) #3
http://codereview.chromium.org/18445/diff/1/2
File test/mjsunit/mirror-object.js (right):

http://codereview.chromium.org/18445/diff/1/2#newcode139
Line 139: if (properties[i].value().isNumber() &&
isNaN(properties[i].value().value())) {
On 2009/01/21 09:18:34, Mads Ager wrote:
> A couple of long lines here.

I know, it is in a mjsunit test, which have a lot of long lines already.

Powered by Google App Engine
This is Rietveld 408576698