Issue 1844002: Change calling convention of BinaryOperation code generation functions on x64...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1844002: Change calling convention of BinaryOperation code generation functions on x64... (Closed)

Created:
10 years, 7 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Change calling convention of BinaryOperation code generation functions on x64 platform to match ia32 platform. Committed: http://code.google.com/p/v8/source/detail?r=4568

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -36 lines)			Patch
M	src/ia32/codegen-ia32.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/x64/codegen-x64.h	View	2 chunks	+4 lines, -7 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	13 chunks	+28 lines, -27 lines	0 comments	Download

Total messages: 2 (0 generated)

William Hesse

Just change of calling conventions, and making code exactly the same on the two platforms.

10 years, 7 months ago (2010-05-03 09:14:03 UTC) #1

LGTM