Add a UI test for "Encoding" menu

chrome/browser/download/save_page_uitest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "chrome/app/chrome_dll_resource.h"
 #include "chrome/browser/automation/url_request_mock_http_job.h"
 #include "chrome/browser/download/save_package.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/test/automation/browser_proxy.h"
 #include "chrome/test/automation/tab_proxy.h"
 #include "chrome/test/ui/ui_test.h"
 #include "net/url_request/url_request_unittest.h"
 
 const std::wstring kTestDir = L"save_page";
 
 class SavePageTest : public UITest {
  protected:
   SavePageTest() : UITest() {}
 
-  void CheckFile(const std::wstring& client_file,
-                 const std::wstring& server_file,
+  void CheckFile(const std::wstring& generated_file,
+                 const std::wstring& expect_result_file,
                  bool check_equal) {
-    bool exist = false;
-    for (int i = 0; i < 20; ++i) {
-      if (file_util::PathExists(client_file)) {
-        exist = true;
-        break;
-      }
-      Sleep(sleep_timeout_ms());
-    }
-    EXPECT_TRUE(exist);
+    std::wstring expect_result_filepath =
+        UITest::GetTestFilePath(kTestDir, expect_result_file);
 
-    if (check_equal) {
-      std::wstring server_file_name;
-      ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA,
-                                   &server_file_name));
-      server_file_name += L"\\" + kTestDir + L"\\" + server_file;
-      ASSERT_TRUE(file_util::PathExists(server_file_name));
-
-      int64 client_file_size = 0;
-      int64 server_file_size = 0;
-      EXPECT_TRUE(file_util::GetFileSize(client_file, &client_file_size));
-      EXPECT_TRUE(file_util::GetFileSize(server_file_name, &server_file_size));
-      EXPECT_EQ(client_file_size, server_file_size);
-      EXPECT_TRUE(file_util::ContentsEqual(client_file, server_file_name));
-    }
-
-    EXPECT_TRUE(DieFileDie(client_file, false));
+    ASSERT_TRUE(file_util::PathExists(expect_result_filepath));
+    WaitForGeneratedFileAndCheck(generated_file,
+                                 expect_result_filepath,
+                                 check_equal, true);
   }
 
   virtual void SetUp() {
     UITest::SetUp();
     EXPECT_TRUE(file_util::CreateNewTempDirectory(L"", &save_dir_));
     save_dir_ += FilePath::kSeparators[0];
 
     download_dir_ = GetDownloadDirectory();
     download_dir_ += FilePath::kSeparators[0];
   }
@@ skipping 97 matching lines @@
   scoped_ptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
   automation()->SavePackageShouldPromptUser(false);
   EXPECT_TRUE(browser->RunCommand(IDC_SAVE_PAGE));
   EXPECT_TRUE(WaitForDownloadShelfVisible(tab.get()));
   automation()->SavePackageShouldPromptUser(true);
 
   CheckFile(full_file_name, file_name, false);
   EXPECT_TRUE(DieFileDie(full_file_name, false));
   EXPECT_TRUE(DieFileDie(dir, true));
 }