Change URLRequest to use a ref-counted buffer for actual IO....

net/url_request/url_request_job.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_JOB_H_
 #define NET_URL_REQUEST_URL_REQUEST_JOB_H_
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/ref_counted.h"
 #include "net/base/auth.h"
 #include "net/base/filter.h"
 #include "net/base/load_states.h"
 #include "net/url_request/url_request_status.h"
 
 namespace net {
 class HttpResponseInfo;
+class IOBuffer;
 class UploadData;
 }
 
 class GURL;
 class URLRequest;
 class URLRequestJobMetrics;
 
 // The URLRequestJob is using RefCounterThreadSafe because some sub classes
 // can be destroyed on multiple threads. This is the case of the
 // UrlRequestFileJob.
@@ skipping 41 matching lines @@
   virtual void Kill();
 
   // Called to detach the request from this Job.  Results in the Job being
   // killed off eventually. The job must not use the request pointer any more.
   void DetachRequest();
 
   // Called to read post-filtered data from this Job, returning the number of
   // bytes read, 0 when there is no more data, or -1 if there was an error.
   // This is just the backend for URLRequest::Read, see that function for more
   // info.
-  bool Read(char* buf, int buf_size, int *bytes_read);
+  bool Read(net::IOBuffer* buf, int buf_size, int *bytes_read);
 
   // Called to fetch the current load state for the job.
   virtual net::LoadState GetLoadState() const { return net::LOAD_STATE_IDLE; }
 
   // Called to get the upload progress in bytes.
   virtual uint64 GetUploadProgress() const { return 0; }
 
   // Called to fetch the mime_type for this request.  Only makes sense for some
   // types of requests. Returns true on success.  Calling this on a type that
   // doesn't have a mime type will return false.
@@ skipping 132 matching lines @@
 
   // Called to read raw (pre-filtered) data from this Job.
   // If returning true, data was read from the job.  buf will contain
   // the data, and bytes_read will receive the number of bytes read.
   // If returning true, and bytes_read is returned as 0, there is no
   // additional data to be read.
   // If returning false, an error occurred or an async IO is now pending.
   // If async IO is pending, the status of the request will be
   // URLRequestStatus::IO_PENDING, and buf must remain available until the
   // operation is completed.  See comments on URLRequest::Read for more info.
-  virtual bool ReadRawData(char* buf, int buf_size, int *bytes_read);
+  virtual bool ReadRawData(net::IOBuffer* buf, int buf_size, int *bytes_read);
 
   // Informs the filter that data has been read into its buffer
   void FilteredDataRead(int bytes_read);
 
   // Reads filtered data from the request.  Returns true if successful,
   // false otherwise.  Note, if there is not enough data received to
   // return data, this call can issue a new async IO request under
   // the hood.
   bool ReadFilteredData(int *bytes_read);
 
@@ skipping 37 matching lines @@
   // all the data or an error has been encountered. Set exclusively by
   // NotifyDone so that it is kept in sync with the request.
   bool done_;
 
   // The data stream filter which is enabled on demand.
   scoped_ptr<Filter> filter_;
   // When we filter data, we receive data into the filter buffers.  After
   // processing the filtered data, we return the data in the caller's buffer.
   // While the async IO is in progress, we save the user buffer here, and
   // when the IO completes, we fill this in.
-  char *read_buffer_;
+  net::IOBuffer *read_buffer_;
   int read_buffer_len_;
 
   // Used by HandleResponseIfNecessary to track whether we've sent the
   // OnResponseStarted callback and potentially redirect callbacks as well.
   bool has_handled_response_;
 
   // Expected content size
   int64 expected_content_size_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequestJob);
 };
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_JOB_H_