Change URLRequest to use a ref-counted buffer for actual IO....

chrome/browser/download/download_file.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <Windows.h>
 #include <objbase.h>
 
 #include "chrome/browser/download/download_file.h"
 
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/scoped_ptr.h"
 #include "base/string_util.h"
 #include "base/task.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/download/download_manager.h"
 #include "chrome/browser/profile.h"
 #include "chrome/browser/renderer_host/resource_dispatcher_host.h"
 #include "chrome/browser/tab_contents/tab_util.h"
 #include "chrome/browser/tab_contents/web_contents.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/stl_util-inl.h"
 #include "chrome/common/win_util.h"
 #include "chrome/common/win_safe_util.h"
 #include "googleurl/src/gurl.h"
+#include "net/base/io_buffer.h"
 #include "net/base/net_util.h"
 #include "net/url_request/url_request_context.h"
 
 using base::TimeDelta;
 
 // Throttle updates to the UI thread so that a fast moving download doesn't
 // cause it to become unresponsive (ins milliseconds).
 static const int kUpdatePeriodMs = 500;
 
 // Timer task for posting UI updates. This task is created and maintained by
@@ skipping 222 matching lines @@
 void DownloadFileManager::UpdateDownload(int id, DownloadBuffer* buffer) {
   DCHECK(MessageLoop::current() == file_loop_);
   std::vector<DownloadBuffer::Contents> contents;
   {
     AutoLock auto_lock(buffer->lock);
     contents.swap(buffer->contents);
   }
 
   DownloadFile* download = LookupDownload(id);
   for (size_t i = 0; i < contents.size(); ++i) {
-    char* data = contents[i].first;
+    net::IOBuffer* data = contents[i].first;
     const int data_len = contents[i].second;
     if (download)
-      download->AppendDataToFile(data, data_len);
-    delete [] data;
+      download->AppendDataToFile(data->data(), data_len);
+    data->Release();
   }
 
   if (download) {
     AutoLock lock(progress_lock_);
     ui_progress_[download->id()] = download->bytes_so_far();
   }
 }
 
 void DownloadFileManager::DownloadFinished(int id, DownloadBuffer* buffer) {
   DCHECK(MessageLoop::current() == file_loop_);
@@ skipping 289 matching lines @@
     ui_loop_->PostTask(FROM_HERE, NewRunnableMethod(
         this, &DownloadFileManager::StopUpdateTimer));
 }
 
 // static
 void DownloadFileManager::DeleteFile(const FilePath& path) {
   // Make sure we only delete files.
   if (!file_util::DirectoryExists(path))
     file_util::Delete(path, false);
 }