Issue 1838: Fix proxy code. The pac string was corrupted when a pac...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1838: Fix proxy code. The pac string was corrupted when a pac... (Closed)

Created:
12 years, 3 months ago by Nicolas Sylvain

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), griffinz

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix proxy code. The pac string was corrupted when a pac file was specified. This is because AsciiToWide returns a temporary object, and we use .c_str, but as soon as the line is executed, the object is destroyed and what was pointed by c_str is also deleted. Use a local variable instead. Thanks for griffinz@gmail.com for pointing the issue. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1890

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	net/proxy/proxy_resolver_winhttp.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages