Issue 18378: Added more logging in debug builds for some failure passes, hopefully this...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18378: Added more logging in debug builds for some failure passes, hopefully this... (Closed)

Created:
11 years, 11 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Added more logging in debug builds for some failure passes, hopefully this will let us figure out why we see so mainly unittest failures on the mac but never seem to be able to repro locally. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8316

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	base/message_pump_libevent.cc	View	1	2 chunks	+10 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 11 months ago (2009-01-20 20:49:45 UTC) #2

(L)ucky (G)oldstar

http://codereview.chromium.org/18378/diff/1/2
File base/message_pump_libevent.cc (right):

http://codereview.chromium.org/18378/diff/1/2#newcode89
Line 89: LOG(ERROR) << "pipe() failed, errno: " << errno;
Make these DLOG (debug logging) and just make the <errno.h> #include
unconditional.

Expand Messages | Collapse Messages