Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1373)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webkit/glue/mimetype_unittest.cc

Issue 18349: We should download text/csv mime types instead of displaying them.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/mime_util_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/mimetype_unittest.cc
===================================================================
--- webkit/glue/mimetype_unittest.cc (revision 8256)
+++ webkit/glue/mimetype_unittest.cc (working copy)
@@ -44,10 +44,14 @@
// These files should all be displayed as plain text.
const char* plain_text[] = {
- "text/css",
- "text/foo",
- "text/richext",
- "text/rtf",
+ // It is unclear whether to display text/css or download it.
+ // Firefox 3: Display
+ // Internet Explorer 7: Download
+ // Safari 3.2: Download
+ // We choose to match Safari.
+ // "text/css",
+ "text/javascript",
+ "text/plain",
"application/x-javascript",
};
for (size_t i = 0; i < arraysize(plain_text); ++i) {
« no previous file with comments | « net/base/mime_util_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698