Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 18341003: DevTools: [CodeMirror] Add syntax highlighting for some other languages. (Closed)

Created:
7 years, 5 months ago by vsevik
Modified:
7 years, 5 months ago
Reviewers:
apavlov
Visibility:
Public.

Description

DevTools: [CodeMirror] Add syntax highlighting for some other languages. Added syntax highlighting based on mime type for some other languages. Network loaded resources (Document, Script and Stylesheet content types) now always have canonical mime type. Files loaded from file system and SourceMap sources loaded through inspector backend (via loadResourceForFrontend) now have mime type based on file extension. Added workaround for "php" extension being used for both standalone and html embedded php scripts. BUG= R=apavlov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153407

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : Rebaselined #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1556 lines, -42 lines) Patch
M Source/devtools/devtools.gyp View 1 chunk +11 lines, -5 lines 0 comments Download
M Source/devtools/front_end/CodeMirrorTextEditor.js View 1 2 3 4 5 3 chunks +8 lines, -8 lines 0 comments Download
M Source/devtools/front_end/CompilerScriptMapping.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ContentProviders.js View 2 chunks +58 lines, -0 lines 0 comments Download
M Source/devtools/front_end/FileSystemProjectDelegate.js View 4 chunks +23 lines, -12 lines 0 comments Download
M Source/devtools/front_end/HandlerRegistry.js View 2 chunks +7 lines, -0 lines 0 comments Download
M Source/devtools/front_end/NetworkUISourceCodeProvider.js View 1 chunk +3 lines, -1 line 0 comments Download
M Source/devtools/front_end/ResourceType.js View 1 2 3 1 chunk +56 lines, -0 lines 0 comments Download
M Source/devtools/front_end/SASSSourceMapping.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/SourceFrame.js View 1 2 3 4 3 chunks +5 lines, -2 lines 0 comments Download
M Source/devtools/front_end/SourceMap.js View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/UISourceCode.js View 1 chunk +2 lines, -1 line 0 comments Download
A + Source/devtools/front_end/cm/LICENSE_python View 2 chunks +4 lines, -6 lines 0 comments Download
A Source/devtools/front_end/cm/clike.js View 1 chunk +361 lines, -0 lines 0 comments Download
A Source/devtools/front_end/cm/coffeescript.js View 1 chunk +347 lines, -0 lines 0 comments Download
A Source/devtools/front_end/cm/htmlembedded.js View 1 chunk +73 lines, -0 lines 1 comment Download
A Source/devtools/front_end/cm/php.js View 1 chunk +132 lines, -0 lines 0 comments Download
A Source/devtools/front_end/cm/python.js View 1 chunk +341 lines, -0 lines 0 comments Download
A Source/devtools/front_end/cm/shell.js View 1 chunk +118 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
vsevik
7 years, 5 months ago (2013-07-01 12:26:21 UTC) #1
apavlov
https://codereview.chromium.org/18341003/diff/1/Source/devtools/front_end/SourceMap.js File Source/devtools/front_end/SourceMap.js (right): https://codereview.chromium.org/18341003/diff/1/Source/devtools/front_end/SourceMap.js#newcode117 Source/devtools/front_end/SourceMap.js:117: var extension = lastIndexOfDot !== -1 ? sourceURL.substr(lastIndexOfDot + ...
7 years, 5 months ago (2013-07-01 12:31:29 UTC) #2
apavlov
https://codereview.chromium.org/18341003/diff/3001/Source/devtools/front_end/CodeMirrorTextEditor.js File Source/devtools/front_end/CodeMirrorTextEditor.js (right): https://codereview.chromium.org/18341003/diff/3001/Source/devtools/front_end/CodeMirrorTextEditor.js#newcode489 Source/devtools/front_end/CodeMirrorTextEditor.js:489: switch (mimeType) { Remove themes https://codereview.chromium.org/18341003/diff/3001/Source/devtools/front_end/SourceFrame.js File Source/devtools/front_end/SourceFrame.js (right): ...
7 years, 5 months ago (2013-07-01 12:46:47 UTC) #3
vsevik
7 years, 5 months ago (2013-07-01 13:43:51 UTC) #4
apavlov
lgtm
7 years, 5 months ago (2013-07-01 13:56:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/18341003/1020
7 years, 5 months ago (2013-07-01 13:59:47 UTC) #6
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=2720
7 years, 5 months ago (2013-07-01 14:16:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/18341003/20001
7 years, 5 months ago (2013-07-02 07:33:00 UTC) #8
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=2784
7 years, 5 months ago (2013-07-02 07:47:50 UTC) #9
vsevik
Committed patchset #6 manually as r153407 (presubmit successful).
7 years, 5 months ago (2013-07-02 08:23:58 UTC) #10
paulirish
https://codereview.chromium.org/18341003/diff/20001/Source/devtools/front_end/cm/htmlembedded.js File Source/devtools/front_end/cm/htmlembedded.js (right): https://codereview.chromium.org/18341003/diff/20001/Source/devtools/front_end/cm/htmlembedded.js#newcode73 Source/devtools/front_end/cm/htmlembedded.js:73: CodeMirror.defineMIME("application/x-erb", { name: "htmlembedded", scriptingModeSpec:"ruby"}); Looks like we don't ...
7 years, 5 months ago (2013-07-03 21:20:48 UTC) #11
vsevik
7 years, 5 months ago (2013-07-04 05:21:19 UTC) #12
Message was sent while issue was closed.
On 2013/07/03 21:20:48, paulirish wrote:
>
https://codereview.chromium.org/18341003/diff/20001/Source/devtools/front_end...
> File Source/devtools/front_end/cm/htmlembedded.js (right):
> 
>
https://codereview.chromium.org/18341003/diff/20001/Source/devtools/front_end...
> Source/devtools/front_end/cm/htmlembedded.js:73:
> CodeMirror.defineMIME("application/x-erb", { name: "htmlembedded",
> scriptingModeSpec:"ruby"});
> Looks like we don't include the Ruby mode.

We wanted to be conservative here. In current implementation each file format
means a bit of code that is loaded on startup making it slower.
Do you think we need ruby as well?

Powered by Google App Engine
This is Rietveld 408576698