DevTools: [CodeMirror] Add syntax highlighting for some other languages.

DevTools: [CodeMirror] Add syntax highlighting for some other languages.

Added syntax highlighting based on mime type for some other languages.
Network loaded resources (Document, Script and Stylesheet content types) now always have canonical mime type.
Files loaded from file system and SourceMap sources loaded through inspector backend (via loadResourceForFrontend)
now have mime type based on file extension.
Added workaround for "php" extension being used for both standalone and html embedded php scripts.


BUG=
R=apavlov@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153407

[apavlov, 2013-07-01 12:31:29]

https://codereview.chromium.org/18341003/diff/1/Source/devtools/front_end/Sou...
File Source/devtools/front_end/SourceMap.js (right):

https://codereview.chromium.org/18341003/diff/1/Source/devtools/front_end/Sou...
Source/devtools/front_end/SourceMap.js:117: var extension = lastIndexOfDot !==
-1 ? sourceURL.substr(lastIndexOfDot + 1) : "";
You should definitely extension.toLowerCase()

[apavlov, 2013-07-01 12:46:47]

https://codereview.chromium.org/18341003/diff/3001/Source/devtools/front_end/...
File Source/devtools/front_end/CodeMirrorTextEditor.js (right):

https://codereview.chromium.org/18341003/diff/3001/Source/devtools/front_end/...
Source/devtools/front_end/CodeMirrorTextEditor.js:489: switch (mimeType) {
Remove themes

https://codereview.chromium.org/18341003/diff/3001/Source/devtools/front_end/...
File Source/devtools/front_end/SourceFrame.js (right):

https://codereview.chromium.org/18341003/diff/3001/Source/devtools/front_end/...
Source/devtools/front_end/SourceFrame.js:349: if (mimeType === "text/x-php" &&
content.match(/\<\?.*\?\>/gi))
The "i" flag is not necessary, since you are not checking letters. This might
speed up the regex matching.

[apavlov, 2013-07-01 13:56:08]

lgtm

[commit-bot: I haz the power, 2013-07-01 13:59:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vsevik@chromium.org/18341003/1020

[commit-bot: I haz the power, 2013-07-01 14:16:29]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[commit-bot: I haz the power, 2013-07-02 07:33:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vsevik@chromium.org/18341003/20001

[commit-bot: I haz the power, 2013-07-02 07:47:50]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[vsevik, 2013-07-02 08:23:58]

Committed patchset #6 manually as r153407 (presubmit successful).

[paulirish, 2013-07-03 21:20:48]

https://codereview.chromium.org/18341003/diff/20001/Source/devtools/front_end...
File Source/devtools/front_end/cm/htmlembedded.js (right):

https://codereview.chromium.org/18341003/diff/20001/Source/devtools/front_end...
Source/devtools/front_end/cm/htmlembedded.js:73:
CodeMirror.defineMIME("application/x-erb", { name: "htmlembedded",
scriptingModeSpec:"ruby"});
Looks like we don't include the Ruby mode.

[vsevik, 2013-07-04 05:21:19]

On 2013/07/03 21:20:48, paulirish wrote:
>
https://codereview.chromium.org/18341003/diff/20001/Source/devtools/front_end...
> File Source/devtools/front_end/cm/htmlembedded.js (right):
> 
>
https://codereview.chromium.org/18341003/diff/20001/Source/devtools/front_end...
> Source/devtools/front_end/cm/htmlembedded.js:73:
> CodeMirror.defineMIME("application/x-erb", { name: "htmlembedded",
> scriptingModeSpec:"ruby"});
> Looks like we don't include the Ruby mode.

We wanted to be conservative here. In current implementation each file format
means a bit of code that is loaded on startup making it slower.
Do you think we need ruby as well?