Factor out the message sink from MockRenderThread to a separate class. I will...

Factor out the message sink from MockRenderThread to a separate class. I will be
using this in a RenderView test in the future.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8255

[cpu_(ooo_6.6-7.5), 2009-01-16 20:35:03]

LGTM

Minor nits below.

http://codereview.chromium.org/18326/diff/1/3
File chrome/common/ipc_test_sink.cc (right):

http://codereview.chromium.org/18326/diff/1/3#newcode19
Line 19: // manage its data itself.
Oh noes!, I see that pickle promises that operator= performs deep copy. Since
message seems not to have aditional members couldn't we use that operator?

http://codereview.chromium.org/18326/diff/1/2
File chrome/common/ipc_test_sink.h (right):

http://codereview.chromium.org/18326/diff/1/2#newcode39
Line 39: typedef std::pair<Message, char*> MessagePair;
It seems MessagePair can move to the private or protected section.

[brettw, 2009-01-16 21:37:09]

On 2009/01/16 20:35:03, cpu wrote:
> Oh noes!, I see that pickle promises that operator= performs deep copy. Since
> message seems not to have aditional members couldn't we use that operator?

Turns out I misunderstood how the memory management works. The copy constructor
is OK, and this cleaned a bunch of stuff up. Please see the new patch of
awesomeness.

[cpu_(ooo_6.6-7.5), 2009-01-16 21:58:21]

Me likes it. LGTM