Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 183044: Workaround Skia and Pango measuring font heights differently by asking Pango... (Closed)

Created:
11 years, 3 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Workaround Skia and Pango measuring font heights differently by asking Pango for the height that we'll report in the gfx::Font. This seems wrong, but at least things will look reasonable until we find a better solution. This changes the existing height computation code to use ceiling. Even though this is no longer used, it is good to have the correct code for the height computation here so that if we find a better solution, it will be run properly. This also gives more room for the clock in the status area view because the height is now more and we want it to be aligned properly. BUG=none TEST=none

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M app/gfx/font_skia.cc View 2 chunks +24 lines, -3 lines 0 comments Download
M chrome/browser/views/frame/status_area_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
11 years, 3 months ago (2009-09-01 23:31:29 UTC) #1
James Hawkins
11 years, 3 months ago (2009-09-01 23:33:55 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698