Issue 18299: Changes to make it possible to statically link Gears. This is disabled by an...

Issue 18299: Changes to make it possible to statically link Gears. This is disabled by an... (Closed)

Created:
11 years, 11 months ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Changes to make it possible to statically link Gears. This is disabled by an #ifdef. This only partially works. Missing pieces: - gears resources for HTML dialogs (permissions, shortcut, settings). - able to compile with a non-official gears build. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8238

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 4

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -11 lines)			Patch
M	chrome/common/chrome_plugin_lib.cc	View	1 2 3 4	2 chunks	+14 lines, -0 lines	0 comments	Download
M	gears/SConscript	View	1 2 3 4	4 chunks	+22 lines, -3 lines	0 comments	Download
M	gears/SConscript.browser	View	1 2 3 4	1 chunk	+10 lines, -7 lines	0 comments	Download
M	webkit/glue/plugins/plugin_lib_win.cc	View		3 chunks	+24 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/plugin_list.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/plugins/plugin_list_win.cc	View		1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm http://codereview.chromium.org/18299/diff/19/21 File webkit/glue/plugins/plugin_lib.cc (right): http://codereview.chromium.org/18299/diff/19/21#newcode27 Line 27: #ifdef GEARS_STATIC_LIB I think we'd want to ...

11 years, 11 months ago (2009-01-16 00:53:28 UTC) #2

Matt Perry

11 years, 11 months ago (2009-01-16 01:11:20 UTC) #3

updated

http://codereview.chromium.org/18299/diff/19/21
File webkit/glue/plugins/plugin_lib.cc (right):

http://codereview.chromium.org/18299/diff/19/21#newcode27
Line 27: #ifdef GEARS_STATIC_LIB
On 2009/01/16 00:53:28, John Abd-El-Malek wrote:
> I think we'd want to give these functions gears specific names, because this
is
> pretty generic (i.e. when I look at those definitions it looks like it's for
all
> plugins).  How about Gear_NP_*?

Done.

> Also, perhaps these can be moved into the ifdef below at line 82?

They need to be outside the NPAPI namespace. Also, that #ifdef is inside an
array declaration :).

http://codereview.chromium.org/18299/diff/19/22
File webkit/glue/plugins/plugin_list.cc (right):

http://codereview.chromium.org/18299/diff/19/22#newcode269
Line 269: #ifdef GEARS_STATIC_LIB
On 2009/01/16 00:53:28, John Abd-El-Malek wrote:
> I think you want to move this to the top of the function, before the
> use_internal_activex_shim_ check.

Good catch, thanks!

Expand Messages | Collapse Messages