Issue 18295: The ubuntu version of valgrind doesn't have "--track-origins".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18295: The ubuntu version of valgrind doesn't have "--track-origins". (Closed)

Created:
11 years, 11 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee, Evan Martin, dank

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

The ubuntu version of valgrind doesn't have "--track-origins".

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/valgrind/valgrind_test.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

11 years, 11 months ago (2009-01-16 00:27:39 UTC) #3

Dan, 

It looks like you know something (anything) about valgrind. Evan won't review
these patches because he doesn't know much about valgrind, and Dean appears to
still be asleep. Can you start reviewing these patches?

The buildbot has never run successfully and is only now getting to the point
where it's about to run. I know that this patch isn't going to be the last one
that makes it work. I'm at that awkward point where I have a broken tree but
don't feel like I can stuff these changes in through a TBR...

-- Elliot

Expand Messages | Collapse Messages