Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1771)

Unified Diff: base/ref_counted.cc

Issue 18272: Add thread safety checks but keep them disabled for now until I fix all the c... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/
Patch Set: Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/ref_counted.h ('k') | base/revocable_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/ref_counted.cc
===================================================================
--- base/ref_counted.cc (revision 8075)
+++ base/ref_counted.cc (working copy)
@@ -5,6 +5,7 @@
#include "base/ref_counted.h"
#include "base/logging.h"
+#include "base/thread_collision_warner.h"
namespace base {
@@ -23,6 +24,9 @@
}
void RefCountedBase::AddRef() {
+ // TODO(maruel): Add back once it doesn't assert 500 times/sec.
+ // Current thread books the critical section "AddRelease" without release it.
+ // DFAKE_SCOPED_LOCK_THREAD_LOCKED(add_release_);
#ifndef NDEBUG
DCHECK(!in_dtor_);
#endif
@@ -30,6 +34,9 @@
}
bool RefCountedBase::Release() {
+ // TODO(maruel): Add back once it doesn't assert 500 times/sec.
+ // Current thread books the critical section "AddRelease" without release it.
+ // DFAKE_SCOPED_LOCK_THREAD_LOCKED(add_release_);
#ifndef NDEBUG
DCHECK(!in_dtor_);
#endif
« no previous file with comments | « base/ref_counted.h ('k') | base/revocable_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698