Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 18272: Add thread safety checks but keep them disabled for now until I fix all the c... (Closed)

Created:
11 years, 11 months ago by M-A Ruel
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Add thread safety checks but keep them disabled for now until I fix all the current places where it triggers. Set back StoreRef as non-thread-safe. BUG5689 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8180

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M base/ref_counted.h View 2 chunks +3 lines, -0 lines 0 comments Download
M base/ref_counted.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M base/revocable_store.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
11 years, 11 months ago (2009-01-15 15:18:59 UTC) #1
darin (slow to review)
11 years, 11 months ago (2009-01-16 08:13:38 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698