Issue 1826: Moved some Page menu elements to App menu (they fit there much more); these a...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1826: Moved some Page menu elements to App menu (they fit there much more); these a... (Closed)

Created:
12 years, 3 months ago by ender

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Moved some Page menu elements to App menu (they fit there much more); these are: IDC_NEWTAB, IDC_NEWWINDOW, IDC_GOOFFTHERECORD.

Patch Set 2 : '' #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	AUTHORS	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/views/toolbar_view.cc	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

http://codereview.chromium.org/1826/diff/1/2 File chrome/browser/views/toolbar_view.cc (right): http://codereview.chromium.org/1826/diff/1/2#newcode505 Line 505: menu.AppendMenuItemWithLabel(IDC_PASTE, l10n_util::GetString(IDS_PASTE)); I don't think we should do ...

12 years, 3 months ago (2008-09-09 00:56:47 UTC) #2

ender

> Can you update this CL to have just that change? Thanks Done

12 years, 3 months ago (2008-09-09 17:00:51 UTC) #3