Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 18255: Render maximized mode better when using nonstandard border widths.... (Closed)

Created:
11 years, 11 months ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Render maximized mode better when using nonstandard border widths. This change is a bit gross. It calls out to GetSystemMetrics() all over this code, which just shows how many places are sizing themselves from the window edge instead of from the window border edge. When cleaning this file up to be more sane, I intend to make most of these functions position themselves based on the border edge, which should cut down the number of these calls to just a couple (and perhaps collapse some of the constants together too). BUG=5054 TEST=In both Classic and Luna, use the Display control panel to set your active/inactive border widths to something nonstandard (try 20, that's real noticeable) and maximize a Chrome window. Make sure the window controls appear where you expect instead of partly or totally off the screen edges. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8060

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -69 lines) Patch
M chrome/browser/views/frame/opaque_non_client_view.h View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/views/frame/opaque_non_client_view.cc View 16 chunks +62 lines, -67 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
11 years, 11 months ago (2009-01-15 01:01:55 UTC) #1
sky
11 years, 11 months ago (2009-01-15 01:06:34 UTC) #2
OK

http://codereview.chromium.org/18255/diff/1/2
File chrome/browser/views/frame/opaque_non_client_view.cc (right):

http://codereview.chromium.org/18255/diff/1/2#newcode342
Line 342: // The additional height beyond the system-provided thickness of the
broder on
nit: broder -> border

Powered by Google App Engine
This is Rietveld 408576698