Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 18253: Fix status bubble positioning with custom border widths by positioning the bu... (Closed)

Created:
11 years, 11 months ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix status bubble positioning with custom border widths by positioning the bubble relative to the client area and then converting to parent coordinates instead of trying to position it absolutely with hardcoded constants. Also changes an Offset() call to ConvertPointToView(), which is functionally the same but I think clearer in intent. BUG=5054 TEST=In both Classic and Luna, use the Display control panel to set your active/inactive border widths to something nonstandard (try 20, that's real noticeable) and maximize a Chrome window. Make sure when hovering a link that the status bubble appears aligned with the screen corner instead of partly offscreen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M chrome/browser/views/frame/browser_view.cc View 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
11 years, 11 months ago (2009-01-15 00:51:00 UTC) #1
sky
11 years, 11 months ago (2009-01-15 00:57:59 UTC) #2
LGTM

Don't forget your TEST= to help the testing folks.

Powered by Google App Engine
This is Rietveld 408576698