Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Issue 18243: Remove the build time generation of config.h and xmlversion.h. (Closed)

Created:
11 years, 11 months ago by tony
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove the build time generation of config.h and xmlversion.h. This adds a bat file which will generate config.h and xmlversion.h into the win32 directory. I updated include paths and everything seems to build.

Patch Set 1 #

Patch Set 2 : add sln files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+562 lines, -266 lines) Patch
M chrome/chrome.sln View 12 chunks +1 line, -32 lines 0 comments Download
M chrome/chrome_kjs.sln View 12 chunks +1 line, -34 lines 0 comments Download
M third_party/libxml/README.google View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/libxml/build/generate-win32-headers.bat View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/libxml/build/libxml.vsprops View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libxml/build/libxml_config.bat View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/libxml/build/libxml_config.rules View 1 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/libxml/build/libxml_config.vcproj View 1 chunk +0 lines, -74 lines 0 comments Download
M third_party/libxml/build/using_libxml.vsprops View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/libxml.scons View 1 chunk +4 lines, -26 lines 0 comments Download
A third_party/libxml/win32/config.h View 1 chunk +124 lines, -0 lines 0 comments Download
A third_party/libxml/win32/include/libxml/xmlversion.h View 1 chunk +415 lines, -0 lines 0 comments Download
M webkit/build/JavaScriptCore/JavaScriptCore.vcproj View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/webkit.sln View 7 chunks +1 line, -23 lines 0 comments Download
M webkit/webkit_armu.sln View 7 chunks +1 line, -23 lines 0 comments Download
M webkit/webkit_kjs.sln View 6 chunks +1 line, -23 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tony
11 years, 11 months ago (2009-01-14 22:38:21 UTC) #1
Peter Kasting
Tony and I chatted some over IM about this. The main goal of this change ...
11 years, 11 months ago (2009-01-14 23:15:29 UTC) #2
tony
11 years, 11 months ago (2009-01-14 23:53:39 UTC) #3
Adding darin and dean who may have comments.

Powered by Google App Engine
This is Rietveld 408576698