Issue 18214: Collect some metrics on nosniff. There is some concern that respecting this ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18214: Collect some metrics on nosniff. There is some concern that respecting this ... (Closed)

Created:
11 years, 11 months ago by abarth-chromium

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Collect some metrics on nosniff. There is some concern that respecting this header causes more harm than good. R=darin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8257

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -2 lines)			Patch
	M	base/histogram.h	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
	M	chrome/browser/renderer_host/buffered_resource_handler.cc	View	1 2 3	2 chunks	+31 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

11 years, 11 months ago (2009-01-15 07:28:38 UTC) #2

LGTM

http://codereview.chromium.org/18214/diff/6/7
File base/histogram.h (right):

http://codereview.chromium.org/18214/diff/6/7#newcode383
Line 383: DISALLOW_EVIL_CONSTRUCTORS(BooleanHistogram);
the new hotness is DISALLOW_COPY_AND_ASSIGN, but consistency with the rest of
the file is probably better :-/

http://codereview.chromium.org/18214/diff/6/8
File chrome/browser/renderer_host/buffered_resource_handler.cc (right):

http://codereview.chromium.org/18214/diff/6/8#newcode27
Line 27: if (sniffing_blocked) {
perhaps this can be combined with the code block above since the conditions are
the same?  or did you mean for the conditions to be different?

Expand Messages | Collapse Messages