Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: test/cctest/test-utils.cc

Issue 182043: Change a cast to make MacOS compiler happy.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 CHECK_EQ(-1, FastD2I(-1.234)); 151 CHECK_EQ(-1, FastD2I(-1.234));
152 CHECK_EQ(0, FastD2I(0.345)); 152 CHECK_EQ(0, FastD2I(0.345));
153 CHECK_EQ(1, FastD2I(1.234)); 153 CHECK_EQ(1, FastD2I(1.234));
154 CHECK_EQ(1000000, FastD2I(1000000.123)); 154 CHECK_EQ(1000000, FastD2I(1000000.123));
155 // Check that >> is implemented as arithmetic shift right. 155 // Check that >> is implemented as arithmetic shift right.
156 // If this is not true, then ArithmeticShiftRight() must be changed, 156 // If this is not true, then ArithmeticShiftRight() must be changed,
157 // There are also documented right shifts in assembler.cc of 157 // There are also documented right shifts in assembler.cc of
158 // int8_t and intptr_t signed integers. 158 // int8_t and intptr_t signed integers.
159 CHECK_EQ(-2, -8 >> 2); 159 CHECK_EQ(-2, -8 >> 2);
160 CHECK_EQ(-2, static_cast<int8_t>(-8) >> 2); 160 CHECK_EQ(-2, static_cast<int8_t>(-8) >> 2);
161 CHECK_EQ(static_cast<intptr_t>(-2), static_cast<intptr_t>(-8) >> 2); 161 CHECK_EQ(-2, static_cast<int>(static_cast<intptr_t>(-8) >> 2));
162 } 162 }
163 163
164 164
165 TEST(SNPrintF) { 165 TEST(SNPrintF) {
166 // Make sure that strings that are truncated because of too small 166 // Make sure that strings that are truncated because of too small
167 // buffers are zero-terminated anyway. 167 // buffers are zero-terminated anyway.
168 const char* s = "the quick lazy .... oh forget it!"; 168 const char* s = "the quick lazy .... oh forget it!";
169 int length = strlen(s); 169 int length = strlen(s);
170 for (int i = 1; i < length * 2; i++) { 170 for (int i = 1; i < length * 2; i++) {
171 static const char kMarker = static_cast<char>(42); 171 static const char kMarker = static_cast<char>(42);
172 Vector<char> buffer = Vector<char>::New(i + 1); 172 Vector<char> buffer = Vector<char>::New(i + 1);
173 buffer[i] = kMarker; 173 buffer[i] = kMarker;
174 int n = OS::SNPrintF(Vector<char>(buffer.start(), i), "%s", s); 174 int n = OS::SNPrintF(Vector<char>(buffer.start(), i), "%s", s);
175 CHECK(n <= i); 175 CHECK(n <= i);
176 CHECK(n == length || n == -1); 176 CHECK(n == length || n == -1);
177 CHECK_EQ(0, strncmp(buffer.start(), s, i - 1)); 177 CHECK_EQ(0, strncmp(buffer.start(), s, i - 1));
178 CHECK_EQ(kMarker, buffer[i]); 178 CHECK_EQ(kMarker, buffer[i]);
179 if (i <= length) { 179 if (i <= length) {
180 CHECK_EQ(i - 1, strlen(buffer.start())); 180 CHECK_EQ(i - 1, strlen(buffer.start()));
181 } else { 181 } else {
182 CHECK_EQ(length, strlen(buffer.start())); 182 CHECK_EQ(length, strlen(buffer.start()));
183 } 183 }
184 buffer.Dispose(); 184 buffer.Dispose();
185 } 185 }
186 } 186 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698