third_party/pyftpdlib/README.chromium - Issue 182031: Speed up net_unittests by re-using one FTP test server instance.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/pyftpdlib/README.chromium

Issue 182031: Speed up net_unittests by re-using one FTP test server instance. (Closed)

Patch Set: add google.patch Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 This library was downloaded from http://code.google.com/p/pyftpdlib/	1 This library was downloaded from http://code.google.com/p/pyftpdlib/

2	2

	3 Chromium-specific changes are in google.patch file.
	wtc 2009/08/31 20:38:44 Why don't we name the file chromium.patch? I gues Why don't we name the file chromium.patch? I guess we're not going to submit this patch upstream because it is not useful in general? I believe your change removes the artificial 5-second delay after a login failure. While the 5-second delay makes it hard to try different passwords, we don't need this protection in a ftp server used only for testing. Correct? Perhaps we can submit a patch upstream in which the delay after a login failure is a parameter rather than a hardcoded 5 seconds?? You should explain this patch in this file or in the patch itself.
	4

3 For licensing information please LICENSE file	5 For licensing information please LICENSE file

4	6

5 Python FTP server library provides an high-level portable interface to easily	7 Python FTP server library provides an high-level portable interface to easily

6 write asynchronous FTP servers with Python. Based on asyncore framework	8 write asynchronous FTP servers with Python. Based on asyncore framework

7 pyftpdlib is currently the most complete RFC-959 FTP server implementation	9 pyftpdlib is currently the most complete RFC-959 FTP server implementation

8 available for Python programming language.	10 available for Python programming language.

9	11

10 Version: 0.5.0	12 Version: 0.5.0

11	13

12 Learn more by visiting: http://code.google.com/p/pyftpdlib/wiki/FAQ	14 Learn more by visiting: http://code.google.com/p/pyftpdlib/wiki/FAQ

OLD	NEW