Issue 182027: X64: Obey WIN64 ABI more exactly, in WIN64 build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 182027: X64: Obey WIN64 ABI more exactly, in WIN64 build. (Closed)

Created:
11 years, 3 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64: Obey WIN64 ABI more exactly, in WIN64 build. Committed: http://code.google.com/p/v8/source/detail?r=2791

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -10 lines)			Patch
	M	src/x64/codegen-x64.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
	M	src/x64/macro-assembler-x64.cc	View	1 2	2 chunks	+11 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

We need to make sure that the GC does not touch the space allocated for ...

11 years, 3 months ago (2009-08-31 15:56:28 UTC) #1

Mads Ager (chromium)

11 years, 3 months ago (2009-08-31 16:30:40 UTC) #2

LGTM

http://codereview.chromium.org/182027/diff/1/2
File src/x64/macro-assembler-x64.cc (right):

http://codereview.chromium.org/182027/diff/1/2#newcode1028
Line 1028: subq(rsp, Immediate(0x30));  // 2 pointer structure, plus 4
parameters.
Please write this as 'Immediate(6 * kPointerSize)'.

Expand Messages | Collapse Messages