Issue 182019: It's OK to include sqlite3.h in renderer code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 182019: It's OK to include sqlite3.h in renderer code. (Closed)

Created:
11 years, 3 months ago by dumi

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), rafaelw, Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

It's OK to include sqlite3.h in renderer code. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24838

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/renderer/DEPS	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

OK to green the tree, but let's have Darin take a look at the exact ...

11 years, 3 months ago (2009-08-29 00:06:14 UTC) #1

darin (slow to review)

11 years, 3 months ago (2009-08-29 00:12:30 UTC) #2

http://codereview.chromium.org/182019/diff/1/2
File chrome/renderer/DEPS (right):

http://codereview.chromium.org/182019/diff/1/2#newcode15
Line 15: "+third_party/sqlite/preprocessed",
this is a fine change.  i would even say that you could leave off the
"preprocessed" bit.

one nit: please insert this into alphabetical order

Expand Messages | Collapse Messages