Issue 1820: Compile bspatch only on win32 for now.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1820: Compile bspatch only on win32 for now. (Closed)

Created:
12 years, 3 months ago by kuchhal

Modified:
9 years, 7 months ago

Reviewers:
sgk

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Compile bspatch only on win32 for now. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1858

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	build/SConscript.main	View		2 chunks	+4 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sgk

12 years, 3 months ago (2008-09-08 19:13:57 UTC) #2

http://codereview.chromium.org/1820/diff/1/2
File build/SConscript.main (right):

http://codereview.chromium.org/1820/diff/1/2#newcode476
Line 476: ])
Picky:  I'd add a comment that this is temporary for porting purposes, so
someone  else trying to read the code doesn't mistakenly think that we
specifically intend that bspatch will only build on Windows.

Otherwise, lgtm.

Expand Messages | Collapse Messages