Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: src/platform/update_engine/generate_delta_main.cc

Issue 1819002: AU: delta compress the kernel partition (Closed) Base URL: ssh://git@chromiumos-git/chromeos
Patch Set: fixes for review Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/platform/update_engine/extent_writer_unittest.cc ('k') | src/platform/update_engine/test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/platform/update_engine/generate_delta_main.cc
diff --git a/src/platform/update_engine/generate_delta_main.cc b/src/platform/update_engine/generate_delta_main.cc
index a996fb88e58f4e3a43f4cba7ee90583143e68f7d..32b392300bbbf79aac850c1ee85a95d45fcce479 100644
--- a/src/platform/update_engine/generate_delta_main.cc
+++ b/src/platform/update_engine/generate_delta_main.cc
@@ -27,6 +27,8 @@ DEFINE_string(new_dir, "",
DEFINE_string(old_image, "", "Path to the old rootfs");
DEFINE_string(new_image, "", "Path to the new rootfs");
DEFINE_string(out_file, "", "Path to output file");
+DEFINE_string(old_kernel, "", "Path to the old kernel partition image");
+DEFINE_string(new_kernel, "", "Path to the new kernel partition image");
DEFINE_string(apply_delta, "",
"If set, apply delta over old_image. (For debugging.)");
@@ -78,11 +80,13 @@ int Main(int argc, char** argv) {
LOG(INFO) << "done applying delta.";
return 0;
}
- if (FLAGS_old_dir.empty() || FLAGS_new_dir.empty() ||
- FLAGS_old_image.empty() || FLAGS_new_image.empty() ||
- FLAGS_out_file.empty()) {
- LOG(FATAL) << "Missing required argument(s)";
- }
+ CHECK(!FLAGS_old_dir.empty());
+ CHECK(!FLAGS_new_dir.empty());
+ CHECK(!FLAGS_old_image.empty());
+ CHECK(!FLAGS_new_image.empty());
+ CHECK(!FLAGS_out_file.empty());
+ CHECK(!FLAGS_old_kernel.empty());
+ CHECK(!FLAGS_new_kernel.empty());
if ((!IsDir(FLAGS_old_dir.c_str())) || (!IsDir(FLAGS_new_dir.c_str()))) {
LOG(FATAL) << "old_dir or new_dir not directory";
}
@@ -91,6 +95,8 @@ int Main(int argc, char** argv) {
FLAGS_old_image,
FLAGS_new_dir,
FLAGS_new_image,
+ FLAGS_old_kernel,
+ FLAGS_new_kernel,
FLAGS_out_file);
return 0;
« no previous file with comments | « src/platform/update_engine/extent_writer_unittest.cc ('k') | src/platform/update_engine/test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698