Issue 18186: generate test_shell.pak and hook up loading net resources from

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18186: generate test_shell.pak and hook up loading net resources from (Closed)

Created:
11 years, 11 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

generate test_shell.pak and hook up loading net resources from test_shell.pak. Move the net resource loading into the platform specific files (still a stub on osx).

Patch Set 1 #

Total comments: 1

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -19 lines)			Patch
M	base/data_pack.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/base/net_util.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	webkit/tools/test_shell/SConscript	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_gtk.cc	View	2 chunks	+20 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_mac.mm	View	2 chunks	+6 lines, -0 lines	1 comment	Download
M	webkit/tools/test_shell/test_shell_main.cc	View	3 chunks	+2 lines, -16 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_win.cc	View	3 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

11 years, 11 months ago (2009-01-17 00:29:20 UTC) #2

lg

http://codereview.chromium.org/18186/diff/1/7
File webkit/tools/test_shell/test_shell_mac.mm (right):

http://codereview.chromium.org/18186/diff/1/7#newcode864
Line 864: // TODO(port): Return the requested resource.
NOTIMPLEMENTED()
?

Expand Messages | Collapse Messages